Introduce the S3 sink for consumer groups offsets #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2023 19:50
The sink stores the latest offsets for a group-topic-partition under a key: $bucket/[$prefix]/$group/$topic/$partition Since eventually the latest offset is written, the connector does not need to track the offsets for a given key, thus reducing the complexity. Consumer offsets topic contains OffsetsKey messages and GroupMetadata. The latter is ignored since it deals with the group information.
stheppi
commented
Nov 6, 2023
| case (groupTopicPartition, action) => | ||
| val s3KeySuffix = | ||
| s"${groupTopicPartition.group}/${groupTopicPartition.topic}/${groupTopicPartition.partition}" | ||
| val s3Key = location.prefix.fold(s3KeySuffix)(prefix => s"$prefix/$s3KeySuffix") |
There was a problem hiding this comment.
Prefix set as bucket/a/b/c/
@stheppi fix it
stheppi
commented
Nov 6, 2023
...ect-aws-s3/src/main/scala/io/lenses/streamreactor/connect/aws/s3/storage/AwsS3Uploader.scala
Show resolved
Hide resolved
stheppi
commented
Nov 6, 2023
...cala/io/lenses/streamreactor/connect/aws/s3/sink/config/S3ConsumerGroupsSinkConfigTest.scala
Show resolved
Hide resolved
Ensure the prefix with ending / is corrected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sink stores the latest offsets for a group-topic-partition under a key: $bucket/[$prefix]/$group/$topic/$partition
Since eventually the latest offset is written, the connector does not need to track the offsets for a given key, thus reducing the complexity.
Consumer offsets topic contains OffsetsKey messages and GroupMetadata. The latter is ignored since it deals with the group information.