style: replaced {' '} with to prevent line breaks #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sotatek-SonNguyen16
pushed a commit
to Sotatek-SonNguyen16/shadcn-landing-page
that referenced
this pull request
Sep 11, 2024
…-object fix: fix undefined negRiskMarketID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
I have replaced instances of
{" "}with in several parts of the code. This change was made to improve both the semantics and layout consistency of the project. The (Non-Breaking Space) ensures that specific elements, such as words or phrases, will not break across lines, which can be important for maintaining visual integrity.Reasons for the change:
1 - Preventing Unwanted Line Breaks: By using
, we can prevent text from being broken up in inappropriate places, especially in responsive designs where space is limited.2 - Improved Semantics: The is more semantically correct when the goal is to prevent breakpoints, as it explicitly conveys the intention of keeping elements together.
3 - Visual Consistency: This ensures that elements such as names, phrases, or numbers that should remain on the same line do so, regardless of screen size or resolution.
This change was carefully tested to ensure that the design and layout behave correctly on various screen sizes.