Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor transition_data variable names for consistency #12

Merged

Conversation

sTomerG
Copy link
Contributor

@sTomerG sTomerG commented Sep 20, 2024

⚠️ breaking change

closes #2

This pull request updates the naming of the transition_data variable to transitions_data across multiple files to ensure consistency with the class name and improve code readability. The changes affect the following files:

  • README.md: Updated variable names in usage examples.
  • docs/examples/example_many.py: Adjusted variable names in the examples.
  • tz_canary/infer.py: Refactored function arguments and internal variable names.
  • tz_canary/transitions_data.py: Adjusted variable references in class instantiation and examples.
  • tz_canary/validate.py: Updated function arguments and logic for validating time zones.

@leonoverweel leonoverweel merged commit bc3ffcf into leonoverweel:main Sep 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix naming inconsistency in TransitionsData
2 participants