Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow charger voltage of 0 #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kurthuwig
Copy link

Tesla Model 3 LR AWD reports a voltage if 0 when not plugged in, so it
is not an invalid value.

Tesla Model 3 LR AWD reports a voltage if 0 when not plugged in, so it
is not an invalid value.
@lephisto
Copy link
Owner

I'm not sure if the reported charge value can ever be < 0, i doubt that, so that PR would not make much sense. I will dig into this later this week. Thanks for PR

@kurthuwig
Copy link
Author

As the value is actually 0 with my Model 3, it really makes sense as without it, the software just does not work right. And as it is a validity check for voltage, values below 0V are invalid. Still it more looks like an example for a validator than a real check, so you might also remove the check completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants