fix: PlaceholderText may not display promptly under certain circumsta…

…nces (#1115)
lepoco · Jun 8, 2024 · 150e05d · 150e05d
1 parent 00a4c0c
commit 150e05d
Showing 1 changed file with 19 additions and 3 deletions.
diff --git a/src/Wpf.Ui/Controls/TextBox/TextBox.cs b/src/Wpf.Ui/Controls/TextBox/TextBox.cs
@@ -45,15 +45,16 @@ public class TextBox : System.Windows.Controls.TextBox
         nameof(PlaceholderEnabled),
         typeof(bool),
         typeof(TextBox),
-        new PropertyMetadata(true)
+        new PropertyMetadata(true, OnPlaceholderEnabledChanged)
     );
 
     /// <summary>Identifies the <see cref="CurrentPlaceholderEnabled"/> dependency property.</summary>
     public static readonly DependencyProperty CurrentPlaceholderEnabledProperty = DependencyProperty.Register(
         nameof(CurrentPlaceholderEnabled),
         typeof(bool),
         typeof(TextBox),
-        new PropertyMetadata(true));
+        new PropertyMetadata(true)
+    );
 
     /// <summary>Identifies the <see cref="ClearButtonEnabled"/> dependency property.</summary>
     public static readonly DependencyProperty ClearButtonEnabledProperty = DependencyProperty.Register(
@@ -197,7 +198,7 @@ protected void SetPlaceholderTextVisibility()
                 SetCurrentValue(CurrentPlaceholderEnabledProperty, true);
             }
         }
-        else
+        else if (CurrentPlaceholderEnabled)
         {
             SetCurrentValue(CurrentPlaceholderEnabledProperty, false);
         }
@@ -263,4 +264,19 @@ protected virtual void OnTemplateButtonClick(string? parameter)
 
         OnClearButtonClick();
     }
+
+    private static void OnPlaceholderEnabledChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
+    {
+        if (d is not TextBox control)
+        {
+            return;
+        }
+
+        control.OnPlaceholderEnabledChanged();
+    }
+
+    protected virtual void OnPlaceholderEnabledChanged()
+    {
+        SetPlaceholderTextVisibility();
+    }
 }