Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pkg/dmesg): use common ctime parser #174

Merged
merged 3 commits into from
Nov 13, 2024
Merged

feat(pkg/dmesg): use common ctime parser #174

merged 3 commits into from
Nov 13, 2024

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Nov 10, 2024 •
edited
Loading

Break #157 into smaller PRs.

@gyuho gyuho self-assigned this Nov 10, 2024
@gyuho gyuho added this to the v0.1.6 milestone Nov 10, 2024
photoszzt
photoszzt approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@photoszzt photoszzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall. Why do we need a version that doesn't return error?

photoszzt
photoszzt approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@photoszzt photoszzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall. Why do we need a version that doesn't return error?

@gyuho
Copy link
Contributor Author

gyuho commented Nov 13, 2024

Why do we need a version that doesn't return error?

Let me check if I need it in other PRs. If not, I will remove :)

@gyuho gyuho merged commit fabe1f0 into main Nov 13, 2024
5 checks passed
@gyuho gyuho deleted the dmesg-parser branch November 13, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@photoszzt photoszzt photoszzt approved these changes

Assignees

@gyuho gyuho

Labels
None yet
Projects
None yet
Milestone
v0.1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @photoszzt