Update mothership endpoint #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
reviewed
Sep 29, 2024
gyuho
reviewed
Sep 29, 2024
gyuho
reviewed
Sep 29, 2024
gyuho
reviewed
Sep 30, 2024
gyuho
reviewed
Sep 30, 2024
gyuho
reviewed
Sep 30, 2024
gyuho
reviewed
Sep 30, 2024
Comment on lines
+100
to
+232
| func handleJoinResponse(ctx context.Context, body io.Reader) error { | ||
| dir, err := untarFiles("/tmp/", body) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| scriptPath := filepath.Join(dir, "join.sh") | ||
| return runCommand(ctx, scriptPath, nil) | ||
| } | ||
|
|
||
| func untarFiles(targetDir string, body io.Reader) (string, error) { | ||
| var dir string | ||
| gzipReader, err := gzip.NewReader(body) | ||
| if err != nil { | ||
| return "", fmt.Errorf("failed to create gzip reader: %w", err) | ||
| } | ||
| defer gzipReader.Close() | ||
|
|
||
| tarReader := tar.NewReader(gzipReader) | ||
|
|
||
| for { | ||
| header, err := tarReader.Next() |
There was a problem hiding this comment.
need a separate function in a separate package, but for now, we can keep everything here :)
cardyok
force-pushed
the
update-mothership-endpoint
branch
7 times, most recently
from
a95fa54
to
4e5040d
Compare
cardyok
force-pushed
the
update-mothership-endpoint
branch
5 times, most recently
from
94680fc
to
deec7b8
Compare
cardyok
force-pushed
the
update-mothership-endpoint
branch
8 times, most recently
from
25c8651
to
34e52db
Compare
cardyok
force-pushed
the
update-mothership-endpoint
branch
3 times, most recently
from
b1906f1
to
a5821cd
Compare
gyuho
reviewed
Oct 21, 2024
gyuho
reviewed
Oct 21, 2024
cmd/gpud/command/join.go
Outdated
| // network section | ||
| publicIP, _ := login.PublicIP() | ||
| region := "unknown" | ||
| detectProvider := "" |
There was a problem hiding this comment.
Remove this? Currently hard-coded to tailscale only since we only talk to tailscale public DERP servers:
Lines 73 to 74 in 871533e
(this has nothing to do with node setup or GPUs)
cardyok
force-pushed
the
update-mothership-endpoint
branch
2 times, most recently
from
d06bf1c
to
069b60e
Compare
Signed-off-by: cardyok <[email protected]>
Signed-off-by: cardyok <[email protected]>
Signed-off-by: cardyok <[email protected]>
Signed-off-by: cardyok <[email protected]>
Signed-off-by: cardyok <[email protected]>
Signed-off-by: cardyok <[email protected]>
cardyok
force-pushed
the
update-mothership-endpoint
branch
6 times, most recently
from
b4486f7
to
0ca91af
Compare
Signed-off-by: cardyok <[email protected]>
cardyok
force-pushed
the
update-mothership-endpoint
branch
from
0ca91af
to
ecb7d9b
Compare
gyuho
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.