Skip to content

Commit

Permalink
ran Cargo outdated (#178)
Browse files Browse the repository at this point in the history
* Remove clippy directive

Running "cargo doc" gives this warning

warning: unknown lint: `clippy::needless_pass_by_ref_mut`
   --> src/service/reload.rs:104:9
    |
104 | #[allow(clippy::needless_pass_by_ref_mut)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::needless_pass_by_value`
    |
    = note: `#[warn(unknown_lints)]` on by default

warning: `cargo-leptos` (lib) generated 1 warning

The name "needless_pass_by_ref_mut" was not wrong at the time of writing, it is just stale

https://rust-lang.github.io/rust-clippy/master/index.html#/clippy::needless_pass_by_ref_mut

Additionally this "allow" is no longer needed to get cargo clippy to "pass" as of

cargo clippy --version
clippy 0.1.71 (8ede3aa 2023-07-12)

* ran cargo update

I have trimmed down the list by using the modern versions of a couple of packges.

it a long list ... and can be completely cleared because of this

Cargo.toml
# not using notify 5.0 because it uses Crossbeam which has an issue with tokio
notify = "4.0"
  • Loading branch information
martinfrances107 authored Aug 3, 2023
1 parent 418b9af commit 555a50c
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 22 deletions.
48 changes: 32 additions & 16 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ axum = { version = "0.6", features = ["ws"] }
# not using notify 5.0 because it uses Crossbeam which has an issue with tokio
notify = "4.0"
lazy_static = "1.4"
which = "4.3"
cargo_metadata = { version = "0.15", features = ["builder"] }
which = "4.4"
cargo_metadata = { version = "0.17", features = ["builder"] }
serde_json = "1.0"
wasm-bindgen-cli-support = "0.2"
ansi_term = "0.12"
Expand All @@ -55,10 +55,10 @@ reqwest = { version = "0.11", features = [
"native-tls-crate",
"json",
], default-features = false }
dirs = "4.0"
dirs = "5.0"
camino = "1.1"
dotenvy = "0.15"
itertools = "0.10"
itertools = "0.11"
derive_more = "0.99"
flate2 = "1.0"
zip = { version = "0.6", default-features = false, features = ["deflate"] }
Expand All @@ -70,7 +70,7 @@ semver = "1.0.18"
async-trait = "0.1.72"

[dev-dependencies]
insta = { version = "1.23", features = ["yaml"] }
insta = { version = "1.31.0", features = ["yaml"] }
temp-dir = "0.1"

[features]
Expand Down
1 change: 0 additions & 1 deletion src/service/reload.rs
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ async fn websocket(mut stream: WebSocket) {
});
}

#[allow(clippy::needless_pass_by_ref_mut)]
async fn send(stream: &mut WebSocket, msg: BrowserMessage) {
let site_addr = *SITE_ADDR.read().await;
if !wait_for_socket("Reload", site_addr).await {
Expand Down

0 comments on commit 555a50c

Please sign in to comment.