Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AttributeError: module 'importlib' has no attribute 'metadata' #635

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

zzz-heygen
Copy link
Contributor

@zzz-heygen zzz-heygen commented Mar 21, 2024

fixing #617
What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@codespearhead
Copy link

Can you link this PR to that issue ( #617 ), like this?

@zzz-heygen
Copy link
Contributor Author

As long as you mentioned the number of the issue, Github can automatically link it. If you check the issue page, it says I am referencing the issue.

@codespearhead
Copy link

I'm afraid there's been a misunderstanding here. Referencing an issue is not the same as linking a PR to it, as can be seen in the lower right-hand corner of the page in desktop mode.

GridArt_20240329_120957750.jpg

Mentioning the issue id will only automatically link a PR to it if it's preceded by a specific set of keywords, and "fixing" is not one of them. As per the documentation:

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

@kravuri517
Copy link

Hi, any update on when this fix will be merged? Your assistance is greatly appreciated.

@lepture lepture merged commit 98d8a92 into lepture:master Apr 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants