Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete syntax support for SageTeX #2929

Closed
wants to merge 7 commits into from
Closed

Complete syntax support for SageTeX #2929

wants to merge 7 commits into from

Conversation

shivangp76
Copy link
Contributor

I read through the SageTeX documentation to make sure no commands were missed.

  • A new in_sage() function was added.
  • Bug fix: The texSagetexArg environment is now not considered a mathzone. This comes from the fact that $2+2=\sage{2+2}$ is a valid use of \sage (see SageTeX documentation). The contents of its argument should not be considered math, rather Python code.
  • The \sage and \sagestr commands can be used in a mathzone and not in a mathzone, since their purpose is to just convert their Sage input into LaTeX output. Added support for this.

@shivangp76 shivangp76 changed the title Complete support for SageTeX Complete syntax support for SageTeX Apr 19, 2024
Copy link
Owner

@lervag lervag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I believe we should go forward with this, but I have a few comments.

autoload/vimtex/syntax.vim Outdated Show resolved Hide resolved
autoload/vimtex/syntax.vim Outdated Show resolved Hide resolved
autoload/vimtex/syntax.vim Outdated Show resolved Hide resolved
autoload/vimtex/syntax/p/sagetex.vim Outdated Show resolved Hide resolved
autoload/vimtex/syntax/p/sagetex.vim Outdated Show resolved Hide resolved
autoload/vimtex/syntax/p/sagetex.vim Outdated Show resolved Hide resolved
@shivangp76
Copy link
Contributor Author

Thanks for the feedback! I'm new to Vimscript, so I apologize for the poor code. I made the changes you requested. Let me know what you think.

@lervag
Copy link
Owner

lervag commented Apr 20, 2024

Thanks for the feedback! I'm new to Vimscript, so I apologize for the poor code. I made the changes you requested. Let me know what you think.

No need to apologize! I'm very happy to see the contribution and I'm glad to see you not being too annoyed by my slightly pedantic review comments ;)

As you see, I had one more follow-up comment - I propose to not add the in_sage function at all. But I'm all ears if you want to argue it makes sense to add it.

lervag added a commit that referenced this pull request Apr 20, 2024
lervag added a commit that referenced this pull request Apr 20, 2024
lervag added a commit that referenced this pull request Apr 21, 2024
@lervag lervag closed this Apr 21, 2024
@lervag
Copy link
Owner

lervag commented Apr 21, 2024

Thanks; I've merged this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants