-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete syntax support for SageTeX #2929
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I believe we should go forward with this, but I have a few comments.
Thanks for the feedback! I'm new to Vimscript, so I apologize for the poor code. I made the changes you requested. Let me know what you think. |
No need to apologize! I'm very happy to see the contribution and I'm glad to see you not being too annoyed by my slightly pedantic review comments ;) As you see, I had one more follow-up comment - I propose to not add the |
Thanks; I've merged this now. |
I read through the SageTeX documentation to make sure no commands were missed.
$2+2=\sage{2+2}$
is a valid use of\sage
(see SageTeX documentation). The contents of its argument should not be considered math, rather Python code.\sage
and\sagestr
commands can be used in a mathzone and not in a mathzone, since their purpose is to just convert their Sage input into LaTeX output. Added support for this.