ThreeViewEstimateMetricScene

- Added comment for why loss functions aren't used
lessthanoptimal · Nov 30, 2023 · 67d5fff · 67d5fff
1 parent d754581
commit 67d5fff
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/...oofcv-reconstruction/src/main/java/boofcv/alg/structure/ThreeViewEstimateMetricScene.java b/...oofcv-reconstruction/src/main/java/boofcv/alg/structure/ThreeViewEstimateMetricScene.java
@@ -141,6 +141,12 @@ public ThreeViewEstimateMetricScene() {
 		configSBA.optimizer.type = ConfigNonLinearLeastSquares.Type.LEVENBERG_MARQUARDT;
 		configSBA.optimizer.lm.dampeningInitial = 1e-3;
 		configSBA.optimizer.lm.hessianScaling = false;
+
+		// Using loss function wasn't found to improve results in regression tests
+		// in 3-view regression it was a wash. No runtime improvement either by removing second SBA cycle.
+		// In full-blown reconstructions it degraded a few scenarios.
+//		configSBA.loss.type = ConfigLoss.Type.HUBER;
+//		configSBA.loss.parameter = 1.0;
 	}
 
 	/**