Skip to content

Commit

Permalink
feat: switch from nodejs-bin to nodejs-wheel
Browse files Browse the repository at this point in the history
Wider support for older glibc

Fixes DetachHead#167
  • Loading branch information
lewis6991 committed Apr 25, 2024
1 parent 5205123 commit 5e77b67
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions basedpyright/run_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import sys
from pathlib import Path

from nodejs import node
from nodejs_wheel import executable


def run(script_name: str):
sys.exit(node.call([Path(__file__).parent / f"{script_name}.js", *sys.argv[1:]]))
sys.exit(executable.call_node(Path(__file__).parent / f"{script_name}.js", *sys.argv[1:]))
8 changes: 4 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dev = [
"pylint>=3.0.0a7",
"ruff>=0.2.2",
# required for running node/npm commands for local development if node is not installed globally:
"nodejs-bin[cmd]>=18.4.0a4",
"nodejs-wheel>=20.12.2",
]

[tool.pdm.version]
Expand All @@ -32,8 +32,8 @@ authors = [
{ name = "detachhead", email = "[email protected]" },
]
dependencies = [
# required by the basedpyright cli & langserver wrapper scripts, the cmd extra is not needed downstream tho
"nodejs-bin>=18.4.0a4",
# required by the basedpyright cli & langserver wrapper scripts
"nodejs-wheel>=20.12.2",
]
requires-python = ">=3.8"
readme = "README.md"
Expand All @@ -50,7 +50,7 @@ basedpyright-langserver = 'basedpyright.langserver:main'
requires = [
"pdm-backend",
# required when building because some transient dependencies call node/npm scripts relying on it being in the PATH
"nodejs-bin[cmd]>=18.4.0a4",
"nodejs-wheel>=20.12.2",
]
build-backend = "pdm.backend"

Expand Down

0 comments on commit 5e77b67

Please sign in to comment.