Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issues with Doctrine. #460

Open
wants to merge 2 commits into
base: 6.0
Choose a base branch
from
Open

Conversation

ouss-oud
Copy link

No description provided.

@bartmcleod
Copy link
Collaborator

@ouss-oud Could you please also backport the github actions from master? So that unit tests will run here. If they pass, it can be merged.

@bartmcleod
Copy link
Collaborator

@ouss-oud Thank you for your effort. It looks very clever, I don't fully understand it, but I know it is not what I meant. I mean that we have a github action in master that runs the unit tests for each PR. That one was probably introduced after the 6.0 branch was separated and should be backported manually into this PR to make the unit tests run. I hope this is clearer. We should not automatically backport as this will cause issues.

@ouss-oud
Copy link
Author

@bartmcleod I copied .github/workflows/php.yml from master branch

@bartmcleod
Copy link
Collaborator

@ouss-oud Thank you, this is what I meant. I suppose that the composer script is still missing: it will need to be copied manually from composer.json in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants