This repository has been archived by the owner on May 18, 2021. It is now read-only.
Filter IR visits #109
Draft
Filter IR visits #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandcha
commented
Oct 1, 2020
Comment on lines
+11
to
+17
| var pagePath = window.location.pathname; | ||
| var isConnectionPage = pagePath.includes("connection"); | ||
| _paq.push(['setDocumentTitle', isConnectionPage ? pagePath.substring(0, pagePath.lastIndexOf('/')) : pagePath]); | ||
| if (!isConnectionPage){ | ||
| _paq.push(['trackPageView']); | ||
| _paq.push(['enableLinkTracking']); | ||
| }; |
There was a problem hiding this comment.
@LoicPoullain @magemax A priori, pour les visites à /connection/..., nous ne voulons pas mémoriser l'URL en entier. À la recherche de comment ne garder que /connection, j'ai ajouté la modification incomplète ci-dessus.
À ce stade, elle ignore complètement les visites à /connection et ne comptabilise par la redirection automatique vers /ir (voire ne comptabilise plus rien si on ne relance pas la page ?). N'hésitez pas à modifier ce code si vous trouvez la solution !
|
@sandcha cette PR est en draft. Qu'en est-il ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.