Edge-Node-Cluster cleanup KubeVolumeInfo and KubeStorageInfo #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewd-zededa
commented
Sep 20, 2024
andrewd-zededa
commented
- StorageHealthStatus should be under KubeVolumeInfo as a substatus.
- New enum ServiceStatus more appropriately describes multi-node service health.
- Added missing enum entries to StorageVolumeReplicaStatus
|
Moved a field from KubeStorageInfo to KubeVolumeInfo but I'm hoping it should be ok as these should not be in use yet as they were just added recently in PR #63 |
StorageHealthStatus should be under KubeVolumeInfo as a substatus. New enum ServiceStatus more appropriately describes multi-node service health. Added missing enum entries to StorageVolumeReplicaStatus Signed-off-by: Andrew Durbin <[email protected]>
Signed-off-by: Andrew Durbin <[email protected]>
andrewd-zededa
force-pushed
the
volume-health
branch
from
880341f
to
3386156
Compare
|
latest push should resolve yetus enum prefix issue |
eriknordmark
approved these changes
Sep 24, 2024
|
@eriknordmark I believe that eve-api version has been pulled into a dev branch of a controller but I don't think it has been pushed to a release of a production facing controller yet. I think @xyuria-zededa can help confirm. |
I haven't used it yet, so you can feel free to change anything there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.