Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disconnected port handling #2416

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Fix disconnected port handling #2416

merged 7 commits into from
Oct 1, 2024

Conversation

edwardalee
Copy link
Collaborator

@edwardalee edwardalee commented Oct 1, 2024

This fixes #1433 and #1489.

@lhstrh
Copy link
Member

lhstrh commented Oct 1, 2024

Is there anything material to the fix in the reactor-c update?

@edwardalee
Copy link
Collaborator Author

Is there anything material to the fix in the reactor-c update?

No, but I'm testing with reactor-c/main, so it needs to be aligned.

test/C/src/TriggerIssue.lf Outdated Show resolved Hide resolved
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edwardalee edwardalee added this pull request to the merge queue Oct 1, 2024
Merged via the queue into master with commit b69b696 Oct 1, 2024
24 checks passed
@edwardalee edwardalee deleted the disconnected-port branch October 1, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mode transition fails to trigger in some cases
2 participants