Zephyr make kernel clock default + improvements #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also does following improvements: - Use timed wait on semaphore instead of a busy-wait for sleeping - Use Zephyr API for getting a monotonically increasing time.
This was referenced Mar 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Oh, looks like macOS is failing 😞 |
|
But I see now that |
|
Yes, this should not affect macOS as we only build and test Zephyr with a Linux host |
|
Dont know what to make of it. No useful output from the CI and it passed when I re-ran it.. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
FYI: I added the |
|
The macOS test failures can not come from any changes introduced here, so there is a problem already in |
|
Seems to be: |
|
Could you mark it as failing and create an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had some issues with using the Zephyr Counter API as the timing service, it is implemented differently for different boards and did not work for a STM32 board which was reported by a user on Zulip. I had other similar reports also earlier. Therefore, I want to make the Zephyr Kernel time API the default, it gives less precise timing, but it is simple and supported by all boards with Zephyr.
The Counter API can still be used, if the board supports it, but it is not the default.
Docs: lf-lang/lf-lang.github.io#247
Lingua-franca: lf-lang/lingua-franca#2248