Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action is_present field not being reset #482

Merged
merged 11 commits into from
Sep 29, 2024
Merged

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Sep 24, 2024

Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll look at the lingua-franca PR next.

core/environment.c Show resolved Hide resolved
core/reactor_common.c Outdated Show resolved Hide resolved
@erlingrj
Copy link
Collaborator Author

@edwardalee there is still some issue with that I am debugging. I can ping you when it is resolved!

@edwardalee
Copy link
Contributor

@edwardalee there is still some issue with that I am debugging. I can ping you when it is resolved!

Looking more closely at this:

temp.pr(
    enclaveStruct
        + ".is_present_fields["
        + CUtil.bankIndex(instance)
        + " + "
        + enclaveInfo.numIsPresentFields
        + " + count] = &"
        + portRef
        + con
        + "is_present;");

I think maybe instead of bankIndex(instance) it should be bankIndex(port.getParent()).

@lhstrh lhstrh added this pull request to the merge queue Sep 29, 2024
Merged via the queue into main with commit 0c56119 Sep 29, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants