Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieval of reactor-ts via git and not the local filesystem #298

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Retrieval of reactor-ts via git and not the local filesystem #298

merged 1 commit into from
Aug 22, 2024

Conversation

byeonggiljun
Copy link
Collaborator

No description provided.

@byeonggiljun byeonggiljun force-pushed the ci-script branch 3 times, most recently from bb4a729 to def9b85 Compare August 21, 2024 22:32
@byeonggiljun byeonggiljun mentioned this pull request Aug 22, 2024
Closed
@lhstrh
Copy link
Member

lhstrh commented Aug 22, 2024

Looks like a good solution to me!

@lhstrh
Copy link
Member

lhstrh commented Aug 22, 2024

That makes me wonder though; how does this work in the lingua-franca repo? The same fix wouldn't work there.

@lhstrh
Copy link
Member

lhstrh commented Aug 22, 2024

On lingua-franca#master we use the default package.json which currently points to git://github.com/lf-lang/reactor-ts.git#master. So we are testing against the correct runtime, it seems.

@byeonggiljun
Copy link
Collaborator Author

byeonggiljun commented Aug 22, 2024 •
edited
Loading

On lingua-franca#master we use the default package.json which currently points to git://github.com/lf-lang/reactor-ts.git#master. So we are testing against the correct runtime, it seems.

I also think so :)

@byeonggiljun byeonggiljun requested a review from lhstrh August 22, 2024 05:01
@byeonggiljun byeonggiljun marked this pull request as ready for review August 22, 2024 05:01
lhstrh
lhstrh approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lhstrh lhstrh changed the title Fix on the runtime for the CI test Retrieve reactor-ts via git and not the local filesystem Aug 22, 2024
@lhstrh lhstrh changed the title Retrieve reactor-ts via git and not the local filesystem Retrieval of reactor-ts via git and not the local filesystem Aug 22, 2024
@byeonggiljun byeonggiljun merged commit 60fc251 into master Aug 22, 2024
8 checks passed
@byeonggiljun byeonggiljun deleted the ci-script branch August 22, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
bugfix ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byeonggiljun @lhstrh