Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: naming contract on sepolia #38

Merged
merged 5 commits into from
May 30, 2024
Merged

fix: naming contract on sepolia #38

merged 5 commits into from
May 30, 2024

Conversation

Th0rgal
Copy link
Member

@Th0rgal Th0rgal commented May 29, 2024

This pull request updates naming contract address on sepolia. I updated version string in packages/core/package.json but not in package.json. I am not sure which one is the best. The first was more recent.

@Th0rgal Th0rgal requested a review from irisdv May 29, 2024 13:52
@Th0rgal Th0rgal self-assigned this May 29, 2024
@Th0rgal Th0rgal added the 🔥 Ready for review This pull request needs a review label May 29, 2024
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Th0rgal
Copy link
Member Author

Th0rgal commented May 29, 2024

@irisdv looks like it still fails

@irisdv irisdv merged commit 27dea85 into main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants