fix(variant): SKFP-900 summary variant (Ferlab-Ste-Justine#401)

lflangis · Mar 5, 2024 · 3b2ee7e · 3b2ee7e
1 parent 88f7fdb
commit 3b2ee7e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 18 deletions.
diff --git a/packages/ui/Release.md b/packages/ui/Release.md
@@ -1,3 +1,6 @@
+### 9.6.4 2024-03-05
+- fix: SKFP-900 style fix
+
 ### 9.6.3 2024-03-05
 - fix: SKFP-900 variant summary fixes
 

diff --git a/packages/ui/package-lock.json b/packages/ui/package-lock.json
diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@ferlab/ui",
-    "version": "9.6.3",
+    "version": "9.6.4",
     "description": "Core components for scientific research data portals",
     "publishConfig": {
         "access": "public"

diff --git a/packages/ui/src/pages/EntityPage/EntityVariantSummary/index.module.scss b/packages/ui/src/pages/EntityPage/EntityVariantSummary/index.module.scss
@@ -102,9 +102,6 @@
     margin-bottom: 12px;
 }
 
-.detailsItemLabel {
-    color: $gray-7;
-}
 .ant-descriptions-item-label::after {
     margin: 0 8px 0 0;
 }

diff --git a/packages/ui/src/pages/EntityPage/EntityVariantSummary/index.tsx b/packages/ui/src/pages/EntityPage/EntityVariantSummary/index.tsx
@@ -72,20 +72,14 @@ export const EntityVariantSummary = ({ data, id, loading, noDataLabel }: ISummar
                                     <Space direction="horizontal" size="middle">
                                         <Descriptions column={1}>
                                             {detailsLeftSectionCol1?.map((item: IDataItem, index: number) => (
-                                                <Descriptions.Item
-                                                    key={index}
-                                                    label={<span className={style.detailsItemLabel}>{item.label}</span>}
-                                                >
+                                                <Descriptions.Item key={index} label={<span>{item.label}</span>}>
                                                     <span className={style.detailsItemValue}>{item.value}</span>
                                                 </Descriptions.Item>
                                             ))}
                                         </Descriptions>
                                         <Descriptions column={1}>
                                             {detailsLeftSectionCol2?.map((item: IDataItem, index: number) => (
-                                                <Descriptions.Item
-                                                    key={index}
-                                                    label={<span className={style.detailsItemLabel}>{item.label}</span>}
-                                                >
+                                                <Descriptions.Item key={index} label={<span>{item.label}</span>}>
                                                     <span className={style.detailsItemValue}>{item.value}</span>
                                                 </Descriptions.Item>
                                             ))}
@@ -101,10 +95,7 @@ export const EntityVariantSummary = ({ data, id, loading, noDataLabel }: ISummar
                                             title={<span className={style.detailsTitle}>{detail.title}</span>}
                                         >
                                             {detail.items.map((item: IDataItem, index: number) => (
-                                                <Descriptions.Item
-                                                    key={index}
-                                                    label={<span className={style.detailsItemLabel}>{item.label}</span>}
-                                                >
+                                                <Descriptions.Item key={index} label={<span>{item.label}</span>}>
                                                     <span className={style.detailsItemValue}>{item.value}</span>
                                                 </Descriptions.Item>
                                             ))}