feat: add settings.compiler.flags
#45
Merged
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2024
dylon
requested changes
Dec 23, 2024
There was a problem hiding this comment.
We need to change the configuration type of the compiler flags to be an array of strings and DRY up how we concatenate the flags, but this looks good otherwise. I'll submit a PR against this feature branch with my proposals so I don't block you.
EDIT: Here are my recommended changes: Pranavchiku#1
|
@dylon thanks for the review! Feel free to cherry-pick required commits here directly. I’ll be on work in around 1.5 hrs from now. So if you can wrap this, it would be awesome. |
|
@dylon if you could please finish it, that would be great. @Pranavchiku is focusing on module location information which will take some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
compilerFlagsoption to settings.