Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes infinite loop while extracting definitions from invalid ranges #51

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Fixes infinite loop while extracting definitions from invalid ranges #51

merged 1 commit into from
Dec 24, 2024

Conversation

dylon
Copy link
Collaborator

@dylon dylon commented Dec 24, 2024 •
edited
Loading

Changes:

  • Fixes infinite loop while extracting definitions from invalid character ranges
  • Adds support for external document symbols
  • Simplifies the logging mechanism by capturing the log context within a closure
  • Adds bug reporting mechanism to capture when the character ranges are out-of-bounds while extracting definitions

Addresses #50

@dylon
Fixes infinite loop while extracting definitions from invalid charact…
74d1e31 
…er ranges; adds support for external document symbols; simplifies the logging mechanism by capturing the log context within a closure; adds bug reporting mechanism to capture when the character ranges are out-of-bounds while extracting definitions
certik
certik approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is fine, thanks!

I am guessing there is a bug in LFortran also, which this PR now exposes, so we still need to fix it in LFortran also.

@certik certik merged commit bc065ca into lfortran:main Dec 24, 2024
5 checks passed
@dylon dylon deleted the dylon/issue-50 branch December 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylon @certik