-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a number of bugs, including issue #55 #56
Conversation
…nal documents; resolves the canonical paths of includes; corrects off-by-one errors on changes to the line numbers from lfortran; adds support for matching completions against all symbols in the document; corrects the completion kinds by mapping them from type SymbolKind to type CompletionItemKind; corrects the mtime type of FileCacheEntry to Date; resolves file paths while extracting definitions; corrects highlighting and query extraction logic by matching against type strings in additional to symbol literals; depends on lfortran when extracting hover previews; removes LFortranLanguageServer.renameSymbol since it has been deprecated and replaced with the analogous method of LFortranCLIAccessor; corrects unit and integration tests for latest changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that looks good, thanks for fixing the bugs!
I had to resolve some conflicts. Hopefully I did it correctly. If not, you can fix it in subsequent PRs. |
4b6f936
to
5cdc3a9
Compare
@dylon the CI fails. Let's get this fixed and merged. We need to do another round of bug hunting. We fixed a lot of things in LFortran, but there might be more issues. |
d8861ed
to
1130f0f
Compare
The integration test keeps hitting a timeout while awaiting a DOM state change. I cannot reproduce this locally. I will update the dependencies and try again. |
Changes:
To understand the changes to text highlighting and query extraction, consider global.f90 from the SNAP repo:
When the cursor hovers over
r_kind
, all instances ofr_kind
should be highlighted, including those representingREAL
type suffixes: