New macOS Launcher and macOS deprecation & nomenclature fixes #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced OSX_Launcher.sh with macOS_Launcher.sh, which fixes the following issues: * Old launcher did not check all necessary ports per README.md * Old launcher did not search for UDP listeners due to improper lsof usage * Old launcher (self-admittedly) used legacy calls which are soon to be removed from macOS * Old launcher did not properly pass arguments to Responder.py * Old launcher set `bash -x`, causing unwanted debug output * Old launcher used the legacy "OSX" moniker, which Apple has abandoned and replaced with "macOS" Additionally, README.md has been updated to replace legacy service stopping methods with modern ones.
Mac OS X is now (and once again) called "macOS". This may seem trivial, but newer users will become confused as time goes on if this is not corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due primarily to improper usage of
lsof, the old OSX Launcher did not perform all necessary tasks to prep the environment for running Responder. Overall:Replaced OSX_Launcher.shwithmacOS_Launcher.sh, which fixes the following issues:README.mdlsofusagebash -x, causing unwanted debug outputAdditionally,
README.mdhas been updated to replace legacy service-stopping methods with modern ones.