-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing DGE data into EnrichmentBrowser #23
Comments
Thanks for contacting us. I'd say you are good to go with the master branch, and you'll find documentation and working examples when using I conducted a number of tests that were looking good, but you would be def among the first users, so I'd be interested in how this works for you and whether we need to extend the functionality further. |
Alright, thank you that's great! I'll use this issue as a forum to discuss. |
Consider adding in functionality for gsub("\\..*", "", row.names(ens_table)) |
let's make this another issue ("ENSEMBL ID version conversion"), and let's use the current issue for focusing on functionality of |
@lgeistlinger , thank-you for the update! (esp. import).
I have 4 questions for you:
|
Thanks for testing + raising these issues @vivek-verma202! |
Thanks, good-luck with your grant application! |
Alright here is an update for you @lgeistlinger. I've been using import and I have a few suggestions. For importing limma data I think there needs to be a way for using data from the limma-trend approach. Check page 72 on the limma user guide. Instead of using voom: Lines 120 to 132 in 4357b80
You would use the limma-trend method: #' # (5) import from trend/limma (RNA-seq count data)
#' # (5a) create the expression data object
#' library(limma)
#' keep <- filterByExpr(counts, rdesign)
#'
> logCPM <- edgeR::cpm(counts[keep,], log=TRUE, prior.count=3)
#' # (5b) obtain differential expression results
> fit <- lmFit(logCPM, design)
> fit <- eBayes(fit, trend=TRUE)
> res <- topTable(fit, coef=ncol(design))
#'
#' # (5c) import???
#' se <- import(el, res) |
Hi @lgeistlinger, hope your grant application went well. I was wondering if you had a chance to look into the "limitations" of current Hope to hear from you, soon. |
Hi @vivek-verma202, Thanks for your patience. The application has been a sprint involving daily 12 h shifts for the last 7 days Concerning your questions:
(inspecting resulting DE measures against
If you are interested in those, or in general methods that only work on the DE i) make use of the • beta: Log2 fold change significance level. Defaults to 1 (2-fold). • sig.stat: decides which statistic is used for determining
Example: if you wanted to conduct a SPIA analysis with genes rendered differentially expressed (DE genes) that have an absolute log2 fold change > 1 and an adjusted p-value < 0.1, you would call:
ii) If not otherwise specified (eg via the
You can always override / abuse this column by eg setting it
as per default, sbea and nbea methods that work only on a list of DE genes Note the:
Hope that helps and don't hesitate to inquire further if some things are unclear. |
Thank you so much, @lgeistlinger !
Normalization worked but excluded ~91 % of genes:
The results were from DESeq2 and not from raw read counts. Considering the vignette, I am not sure if normalization is needed. Also, DESeq2 output already has normalization factors: How can I make use of DESeq2's normalization factors to normalize the count slot and create "norm" slot in an SE? |
Hi @vivek-verma202 -
is the right thing todo here. I'll add an argument to There are some helpful accessor functions such as A fast approximation of what
But I agree, that's something that |
Hi guys. I'm starting to work with
EnrichmentBrowser
, and I'm running into some issues. I'm looking at porting in DGE data from different sources (DESeq2
,limma
, andedgeR
). My biggest problem is getting these objects into the proper format (SummarizedExperiment
).After exploring this repo some more, I noticed your changelog has a bullet for new import functions for deseq/limma/edgeR. This would be super helpful, so I don't have to write my own functions. So, how stable are they right now? Is the master branch "ok" to use in its current form?
The text was updated successfully, but these errors were encountered: