Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clark #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Clark #45

wants to merge 3 commits into from

Conversation

scrublam
Copy link

pls review :)

@ppatra126
Copy link

in your schematic try and make all of your power symbols point upwards and your grounds point downward. that is a standard most designers have for the sake of readability. i'd look at one of the other boards in the github for a good reference.
image

another small thing that is common is to connect your input bypass caps not exactly at your input connector. in the schematic, every node connected to +12v or GND is always connected so doing the bypass caps to the side is the same circuit layout as if you put the caps right next to the connector symbol. this is another thing that mainly helps with readability and making sure your schematic isn't cluttered. here is an example(sorry if this was worded terribly)
image

an nmos is typically a low side driver. what this means is that usually the flow of current when using an nmos as a "switch" should go Power->Load(whatever you want to power)->NMOS->GND. This is because for an nmos, current flows when Vgs(voltage difference between gate to source) exceeds some threshold. In your current setup, this would mean that your gate would have to exceed 12v to turn on. In this circuit, this is not something we can do without external components to boost the voltage. Therefore, your nmos should be on the negative side of your load. In that setup, the voltage at the gate minus the source is just the voltage at the gate since the source is at 0.

let me know if these comments make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants