Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Akshay pcb #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Akshay pcb #46

wants to merge 3 commits into from

Conversation

guytonde
Copy link

only finished schematic so far but wanted to check correctness and design

@guytonde guytonde self-assigned this Oct 25, 2024
@Mikail-Sadic-UT
Copy link

Change the wierd labels to the normal ones, also make power and ground the regular ones. :)
Screenshot 2024-10-25 144739

Like these ones
image

I would also split off your caps off, and just connect them to 12v and gnd.

@IshDeshpa
Copy link
Contributor

image
You probably need a current-limiting resistor here for your gate pin on the MOSFET. This should explain why: https://www.build-electronic-circuits.com/mosfet-gate-resistor/

@IshDeshpa
Copy link
Contributor

image
I would put a part number on this LED, our Standardized Mouser Components should have a bunch of commonly used parts and you can find the LEDs we typically buy there. Then you can select the LED, hit E to edit the properties, and add the part number and possibly datasheet link if you really want.

Once you've selected an LED, make sure that you will not blow it up (https://www.sparkfun.com/tutorials/219).

IshDeshpa
IshDeshpa previously approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@IshDeshpa IshDeshpa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this seems ok to move to layout. Make sure you add footprints to everything.

@IshDeshpa IshDeshpa dismissed their stale review November 1, 2024 00:50

layout first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshDeshpa IshDeshpa IshDeshpa left review comments

@Lakshay983 Lakshay983 Awaiting requested review from Lakshay983

@Mikail-Sadic-UT Mikail-Sadic-UT Awaiting requested review from Mikail-Sadic-UT

At least 1 approving review is required to merge this pull request.

Assignees

@guytonde guytonde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guytonde @Mikail-Sadic-UT @IshDeshpa