Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to pytest #111

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Change to pytest #111

merged 5 commits into from
Jun 12, 2024

Conversation

stenczelt
Copy link
Member

for #110

  • Converted unittest testing suite into pytest
  • Updated dependencies
  • CI: use pytest & run coverage

n.b. Codecov token is needed in the repo.

@ElliottKasoar
Copy link
Contributor

It could be its own PR, but if you're updating dependencies, downgrading ASE (#112) might be sensible here.

poetry run pytest --cov=abcd --cov-report xml --cov-report term:skip-covered

- name: Upload coverage reports to Codecov
uses: codecov/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for pinning to 4.0.1 specifically? I think the most recent release is 4.4.1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no special intention, the codecov instructions provided this snippet

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 12, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@stenczelt stenczelt merged commit a25a5c2 into libAtoms:master Jun 12, 2024
6 checks passed
@stenczelt stenczelt deleted the use-pytest branch June 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants