Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of mesh stitching for non-conforming meshes #3599

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

pmoseley
Copy link

This adds a new flag "merge_boundary_nodes_all_or_nothing" (open to better names?) to stitch_meshes and stitch_surfaces, which can help to avoid scenarios where you would otherwise create a mix of merged and unmerged nodes at a stitched interface.

I've also add a boolean return value to help identify if nodes were actually stitched; I think this should help with #3580 .

Philip Moseley added 3 commits June 28, 2023 17:51
This can help the user determine if two boundaries were unexpectedly non-coincident,
because otherwise no error or warning message is given.
This helps avoid the case where a stitched boundary surface has a mix of merged
(coincident) nodes and unmerged hanging nodes.
@moosebuild
Copy link

moosebuild commented Jun 28, 2023

Job Coverage on f8713a2 wanted to post the following:

Coverage

b06cac #3599 f8713a
Total Total +/- New
Rate 61.88% 61.88% -0.01% 31.58%
Hits 66607 66607 - 6
Misses 41026 41037 +11 13

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 31.58% is less than the suggested 90.0%

This comment will be updated on new commits.

Copy link
Member

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this the way it is ... but as long as we're changing the return value anyway, would it make sense to return the number of matching nodes, rather than just a boolean for whether that number is non-zero? map::size() is supposed to be O(1) (and likewise if we switch to unordered_map later).

@pmoseley
Copy link
Author

It's a good comment; there's not much reason not to return the number.

I think it will only be useful in some rare cases, because if the user doesn't already know the total number of nodes on the boundary they'll be missing some context. But I'm sure there are some cases where it could be useful.

@jwpeterson jwpeterson merged commit b972d34 into libMesh:devel Jul 6, 2023
@pmoseley pmoseley deleted the stitching_all_or_nothing branch July 7, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants