Skip to content

Commit

Permalink
Generate large benchmark files for nightly benchmarks
Browse files Browse the repository at this point in the history
Currently we only generate the "large" benchmark files for the Criterion
benchmarks in our 'bench' CI job, because that is when they are needed.
However, with commit 9d1978e ("Add benchmark for ELF "str2symtab"
creation") it now one of the earlier nightly benchmarks that already
requires one of those files.
Thus, make sure to generate them just a bit earlier.

Signed-off-by: Daniel Müller <[email protected]>
  • Loading branch information
d-e-s-o committed Dec 27, 2024
1 parent 55006ad commit 7d734eb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -390,14 +390,14 @@ jobs:
shell: bash
run: |
echo '```' >> $GITHUB_STEP_SUMMARY
cargo bench --workspace --features=nightly -- bench_ | tee --append $GITHUB_STEP_SUMMARY
cargo bench --workspace --features=nightly,blazesym-dev/generate-large-test-files -- bench_ | tee --append $GITHUB_STEP_SUMMARY
# We use bencher format here for better relation to the above
# but also because it emits less other crap into our summary.
# Note that because libtest does not understand the
# `--output-format` option, we need to specify the benchmark
# binary (`main`) here and have a different invocation for
# libtest style benchmarks above. Sigh.
cargo bench --workspace --bench=main --bench=capi --features=blazesym-dev/generate-large-test-files,blazesym-dev/dont-generate-unit-test-files -- --output-format=bencher | tee --append $GITHUB_STEP_SUMMARY
cargo bench --workspace --bench=main --bench=capi --features=blazesym-dev/dont-generate-unit-test-files -- --output-format=bencher | tee --append $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
clippy:
name: Lint with clippy
Expand Down

0 comments on commit 7d734eb

Please sign in to comment.