Deny todo!() macro in product code
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's employ the help of clippy to prevent todo!() call sites from sneaking into product code. Do so from CI, which is expected to check all crates in the workspace. Signed-off-by: Daniel Müller <[email protected]>
|
See https://github.com/danielocfb/blazesym/actions/runs/6672484997/job/18136482706 for example run. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
=======================================
Coverage 90.31% 90.31%
=======================================
Files 40 40
Lines 5247 5247
=======================================
Hits 4739 4739
Misses 508 508 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's employ the help of clippy to prevent todo!() call sites from sneaking into product code. Do so from CI, which is expected to check all crates in the workspace.