Require that Pod: Clone #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With upcoming changes we are going to support either working with memory mapped ELF data or with data retrieved using regular file I/O APIs. Obviously, from a memory management perspective the two behave differently: where one just requires some massaging of byte slices, the other necessitates heap allocated buffers. In order for our ELF types to play nice with the latter, guarantee that everything implementing Pod also is cloneable. Signed-off-by: Daniel Müller <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #940 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 57 57
Lines 10527 10527
=======================================
Hits 9955 9955
Misses 572 572 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With upcoming changes we are going to support either working with memory mapped ELF data or with data retrieved using regular file I/O APIs. Obviously, from a memory management perspective the two behave differently: where one just requires some massaging of byte slices, the other necessitates heap allocated buffers.
In order for our ELF types to play nice with the latter, guarantee that everything implementing Pod also is cloneable.