Define align_up() helper via macro #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may need additional variants of the align_up() helper function for different integer types in the future. While it is possible to abstract over all the nitty gritty details of generic integer operations, it requires complex trait machinery in the form of the num-traits crate. For us it makes more sense to just duplicate the logic via macros. Prepare for that by defining align_up() in terms of a macro. Signed-off-by: Daniel Müller <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 57 57
Lines 10650 10650
=======================================
Hits 10075 10075
Misses 575 575 ☔ View full report in Codecov by Sentry. |
d-e-s-o
force-pushed
the
topic/align_up-macro
branch
from
599d2c0 to
5c43a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may need additional variants of the align_up() helper function for different integer types in the future. While it is possible to abstract over all the nitty gritty details of generic integer operations, it requires complex trait machinery in the form of the num-traits crate. For us it makes more sense to just duplicate the logic via macros. Prepare for that by defining align_up() in terms of a macro.
Signed-off-by: Daniel Müller <[email protected]