Remove Error enumeration from libbpf-cargo
#609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Error enumeration in libbpf-cargo doesn't really serve any meaningful purposes at this point: sure, it helps users differentiate between build and generation errors, but the difference arguably has no semantic significance that is worth preserving. On top of that, users can always invoke build() and generate() instead of build_and_generate() to have literally the same information at their finger tips. Remove the Error type in favor of just exposing a anyhow::Error, which is probably the most flexible. Signed-off-by: Daniel Müller <[email protected]>
anakryiko
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Errorenumeration inlibbpf-cargodoesn't really serve any meaningful purposes at this point: sure, it helps users differentiate between build and generation errors, but the difference arguably has no semantic significance that is worth preserving. On top of that, users can always invokebuild()andgenerate()instead ofbuild_and_generate()to have literally the same information at their finger tips.Remove the
Errortype in favor of just exposing aanyhow::Error, which is probably the most flexible.