libbpf-cargo: Stop treating clang arguments as a string #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-e-s-o
force-pushed
the
topic/clang-args
branch
from
ee91f11 to
612bcb3
Compare
Make the --debug option to the cargo-libbpf sub-command a global one. This way, we don't have to list it everywhere and it can be provided in more positions, not just after the sub-command. Signed-off-by: Daniel Müller <[email protected]>
Factor out the ClangOpts type as a grouping of various clang related options. In so doing we remove the need for a bunch of duplication and make it easier to add new clang specific options in the future. Signed-off-by: Daniel Müller <[email protected]>
It's horrible practice to treat program arguments as a simple string: nobody knows how to parse them. The current splitting at whitespace boundaries fails subtly or not so subtly the moment we have, say, spaces in a file path or usage of quotations. Work with a proper vector of arguments instead. Signed-off-by: Daniel Müller <[email protected]>
With commit beff188 ("examples: Use vmlinux.h for current architecture") we are having a hard time compiling the examples using the cargo-libbpf command, because the vmlinux.h header file cannot be found. Introduce the --clang-args argument to allow for passing in additional options -- such as an include path -- to the clang invocation. This would also have helped with libbpf#337. Signed-off-by: Daniel Müller <[email protected]>
d-e-s-o
force-pushed
the
topic/clang-args
branch
2 times, most recently
from
a574b09 to
d9f6849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for descriptions.