BLOCKCHAIN-483 FE Congress close motions that have too many nay votes #311
Conversation
|
50% nay votes reached, no button showing |
| @@ -25,6 +26,8 @@ export default function Motion({ | |||
|
|
|||
| const isClosable = voting.ayes.length >= threshold; | |||
|
|
|||
| const isClosableNaye = voting.nays.length >= 50; | |||
There was a problem hiding this comment.
It should be something like voting.nays.length > number_of_congressmen - threshold.
There was a problem hiding this comment.
yes i just take has more than 50 nay votes from task, too literally
| @@ -58,7 +61,7 @@ export default function Motion({ | |||
| <b> | |||
| {voting.nays.length} | |||
| / | |||
| {threshold} | |||
| {(membersCount / 2).toFixed()} | |||
There was a problem hiding this comment.
Doesn't make sense. Why /2?
There was a problem hiding this comment.
If anything this should be membersCount-threshold+1, but TBH I expect this to confuse the hell out of people.
| @@ -25,6 +26,8 @@ export default function Motion({ | |||
|
|
|||
| const isClosable = voting.ayes.length >= threshold; | |||
|
|
|||
| const isClosableNaye = voting.nays.length >= membersCount - threshold; | |||
There was a problem hiding this comment.
This should be a hard inequality (>).
See my previous comment: #311 (comment)
Seems like there's still no understanding of how this works, so let me explain.
Motion can be "closed & executed", when there's enough ayes votes to meet the threshold.
Motion can be "closed", when there's enough nays that we already know that we can't get enough ayes anymore to meet the threshold.
So a few samples:
- 3 members, threshold=2. So 1 nay is OK, but if we get 2 nays then there's only 1 more member left to
potentially cast aye, so we should show theclosebutton - 4 members, threshold=3. So same as before - 1 nay is ok, but 2 nays leaves us with only 2 more potential ayes, which isn't enough for the threshold
- 10 members, threshold=6. Up to 4 nays is OK, as it still leaves 6 members to potentially cast aye. 5 nays is when we know that this will never pass and we can close.
SzymonZiebaNeti
requested review from
kacperzuk-neti and
DorianSternVukotic
No description provided.