Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build instructions do not work, AM_GNU_GETTEXT #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build instructions do not work, AM_GNU_GETTEXT #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ the source tree.
BUILDING FROM SOURCE
======================================================================

Install dependencies
sudo apt install build-essential ca-certificates gcc make automake libtool libguestfs-tools libguestfs-dev libnbd-dev gettext libpcre2-dev libvirt-dev libxml2-dev libjansson-dev libosinfo-1.0-dev ocaml-findlib libvirt-ocaml-dev libguestfs-ocaml-dev libnbd-ocaml-dev
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is not clear - what do you mean by "AM_GNU_GETTEXT"? maybe you mean that the gettext package was missing?

But I think it will be better to use the equivalent of dnf builddep for apt based systems, installing the needed packages based on the package metadata. With this you get all the packages in most cases and there is no need to maintain this packages list.

If we go with actual package list, it should be sorted and formatted as one package per line:

sudo apt install \
    build-essential \
    ca-certificates \
    gcc \
    ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO better instructions would be just:

        apt-get build-dep virt-v2v
        apt-get install autoconf automake libtool-bin gettext


To build from git:

git submodule update --init
Expand Down Expand Up @@ -87,4 +90,4 @@ Optional, used by the test suite:

* guestfish

* OCaml oUnit2
* OCaml oUnit2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change