Re-enable disabled gossipsub test #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
approved these changes
Jul 11, 2024
|
wait, it fails!!! |
|
It does. I have no idea what this test is supposed to be doing, TBH. But it was supposed to be re-enabled. |
Stebalien
force-pushed
the
steb/re-enable-disabled-test
branch
from
f1e397d
to
37aee7f
Compare
|
Still broken... |
And change it to take into account the fact that libp2p now trims connections immediately (when no grace-period is specified) instead of waiting for a timeout.
Stebalien
force-pushed
the
steb/re-enable-disabled-test
branch
from
62ff3c9
to
30c74d2
Compare
|
@vyzo I finally looked into this and fixed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.