chore: update project config #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes linting, readme and project config.
MarcoPolo
force-pushed
the
chore/update-project-config
branch
from
1eff273 to
5e12089
Compare
MarcoPolo
reviewed
Jun 11, 2024
| * async function main () { | ||
| * const node = await createLibp2p({ | ||
| * // other options ... | ||
| * services: { | ||
| * http: http() | ||
| * } | ||
| * }) | ||
|
|
There was a problem hiding this comment.
Was this why docs failed to generate for me?
There was a problem hiding this comment.
No, it's because the package.json description field wasn't found in the README anywhere - basically this bit.
The README had:
> Implementation of WHATWG Fetch with support for multiaddr URIs and libp2p streams. Use HTTP in p2p networks.
..but it was looking for what was in the package.json:
> Implementation of the WHATWG Fetch API on libp2p streams
It could use printing an error message if it can't be found, tbh..
MarcoPolo
force-pushed
the
chore/update-project-config
branch
from
ca8e3cd to
692763b
Compare
3 tasks
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linting, readme and project config.
Closes #3
Change checklist