fix: ensure dial is rejected with an Error (#199)

* fix: ensure dial is rejected with an Error `offer.err` is returned as a string, convert it to an Error * refactor: update error code Co-Authored-By: Jacob Heun <[email protected]> Co-authored-by: Jacob Heun <[email protected]>
libp2p · Feb 3, 2020 · 41f278e · 41f278e
1 parent dbfd6b1
commit 41f278e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -171,7 +171,7 @@ class WebRTCStar {
       // are clueless as to why.
       sioClient.on('ws-handshake', (offer) => {
         if (offer.intentId === intentId && offer.err) {
-          reject(offer.err)
+          reject(errcode(offer.err instanceof Error ? offer.err : new Error(offer.err), 'ERR_SIGNALLING_FAILED'))
         }
 
         if (offer.intentId !== intentId || !offer.answer) {

diff --git a/test/transport/dial.js b/test/transport/dial.js
@@ -74,7 +74,8 @@ module.exports = (create) => {
       try {
         await ws1.dial(maOffline)
       } catch (err) {
-        expect(err).to.exist()
+        expect(err).to.be.an.instanceOf(Error)
+        expect(err).to.have.property('code', 'ERR_SIGNALLING_FAILED')
         return
       }