feat: make runtime features optional in swarm-test #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
reviewed
Sep 13, 2024
| where | ||
| Self: Sized, | ||
| { | ||
| use libp2p_core::{transport::MemoryTransport, upgrade::Version, Transport as _}; | ||
| use libp2p_identity::Keypair; |
There was a problem hiding this comment.
same as the question above, why is the Keypair import moved from the top of the file to duplicated here and in the tokio case?
There was a problem hiding this comment.
When both async-std and tokio runtimes are disabled, top-level import of Keypair is unused and leads to clippy warnings
| use libp2p_swarm::dial_opts::PeerCondition; | ||
| use libp2p_swarm::{self as swarm, dial_opts::DialOpts, NetworkBehaviour, Swarm, SwarmEvent}; | ||
| use libp2p_yamux as yamux; |
There was a problem hiding this comment.
can we maintain these imports and renames?
There was a problem hiding this comment.
Same, these imports are only used in fn new_ephemeral and fn new_ephemeral_tokio. Disabling both runtime features would cause clippy warnings of used imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes a test uses custom swarm building logic and doesn't need
fn new_ephemeral, and sometimes a test usestokioruntime other thanasync-std.This PR adds the
tokioruntime support and makes bothasync-stdandtokioruntimes optional behind features to make it more flexible.Notes & open questions
Change checklist