Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add panic handlers #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add panic handlers #25

wants to merge 1 commit into from

Conversation

marten-seemann
Copy link

@marten-seemann marten-seemann commented Apr 22, 2022

Fixes #22. Unfortunately, there are quite a few places we need to protect here, but there's a lot of DNS message parsing and serialization happening here.

Part of libp2p/go-libp2p#1389.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we could get "stuck" waiting on a goroutine that has died. We probably need some way to cancel the context if any of these functions exit.

@BigLep BigLep added this to the Best Effort Track milestone Sep 9, 2022
@BigLep BigLep added the P3 label Sep 9, 2022
@BigLep
Copy link

BigLep commented Sep 16, 2022

2022-09-16 conversation: there are some additional code changes to do here. Given P3, don't expect to get to it in the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔎 In Review
Development

Successfully merging this pull request may close these issues.

Add panic handlers
3 participants