Fixed remote addr (on Caddy reverse proxy) problem

[jonirrings]

please check

close #15

[jonirrings]

I did not find better way than just adding an else if

to lower case all header names, may bring more operations than an else if and a hashmap.get

do you get any better way?

[SudoDios]

Thank you @jonirrings
There is a better idea.
This problem needs to be solved from the root.
Because problems like this can occur in other cases
This way we will have to write if & else for the rest of our lives 😂.
I created new string type

#[derive(Eq)]
struct UniCaseString(String);

impl PartialEq for UniCaseString {
    fn eq(&self, other: &Self) -> bool {
        self.0.to_lowercase() == other.0.to_lowercase()
    }
}

impl Hash for UniCaseString {
    fn hash<H: Hasher>(&self, state: &mut H) {
        self.0.to_lowercase().hash(state);
    }
}

This is better.
What do you think?
Implement this in the code.
If you have any questions, ask.

[jonirrings]

got it
I'm trying

[jonirrings]

code updated.
I don't like the .into() at request.rs:L204
should we avoid that?

[jonirrings]

any way to avoid the into?

[SudoDios]

Because it's too long?
Remove to_string

[jonirrings]

😂, because I‘d like to modify code as less as possible.
I'm wondering any implicit coercion, which may be bad practice.

This code seems feasible for me now,
Do you have any other suggestions?

[SudoDios]

😅
very great 👍.
thank you.
I will be back in just 3 days.
I am on my way to a place where there is no internet.
If you find something yourself, do it and we will apply it

[jonirrings]

nice~~
enjoy yourself.

[SudoDios]

Hi @jonirrings
Are you sure it's working correctly?
I just tested the code and no headers were being read from the hashmap.
Borrow<str> probably doesn't work properly.

[jonirrings]

sorry for late reply, I was moving house last weekend, 😂no internet either.
my fault, forgot to test after a manual refactor.
I will test and fix this later in the next few days.

[SudoDios]

Okay 👍 😂

[SudoDios]

@jonirrings How are you?

[jonirrings]

@SudoDios just fine, busy decorating house these days,😂
I tried somehow, Borrow<str> did not make it.
maybe use some case-insensitve map?

[SudoDios]

We should use this for a custom hashmap

[jonirrings]

I prefer https://github.com/philipdaniels/case-insensitive-hashmap , maybe a wrapper won't add up too much size?

[jonirrings]

I tried the case insensitive hashmap above, it works out as expected, can you test it later?

librespeed-rs behind caddy, http

librespeed-rs behind caddy, https

librespeed-rs direct connect

It seems Caddy adds a lot of overhead~🤡