Add with_default_handle_and_ip_list_and_hostname #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some platforms, hostname is fixed so system doesn't gurantee hostname conflict when the application uses system hostname. This could be the platform bug but there is a case where the application wants to use specific and unique hostname for their purpose. This change add new function to spawn responder task with the application specific hostname.
|
Thanks for the contribution! We're definitely getting to the point where we should be using the builder pattern |
willstott101
added a commit
that referenced
this pull request
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms, the hostname is fixed, which causes hostname collisions.
In this case, the application must avoid collisions on its own or use a unique hostname. Otherwise, it will cause the Client to malfunction.
There is a way to update the system hostname with hostname::set, but this will affect other applications as well, and cannot be attempted by general applications without CAP_SYS_ADMIN privilege.
This patch adds an interface that can create a Responder with a hostname.