Revert lint exception by setting minor version of protobuf #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry can you rebase or regenerate the lock file? |
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
yubiuser
force-pushed
the
restore/renamed_removed_lints
branch
from
d877972
to
1859975
Compare
|
Sure thing. I rebased and re-generated the lockfile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the changes made in #1328.
Protobuff 3.5.1. fixed the underlying issue (stepancheg/rust-protobuf#733).
librespotalready used version3of this create, but in theCargo.lockit was set to3.4.1. Specifying the minor version of the crate by3.5updated theCargo.lockto use3.5.1