Fix "Up" and "Left" directional input for both Analog sticks for GC Adapter on Retroarch WiiU #15874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should only change how we propagate the control stick controls for the gamecube controller via a gamecube adapter for the Wii U. Before this change the control stick was unusable because only right and down worked. This change removed clamping for the gamecube controller, which allows left and up to work correctly.
We allow this by calling
gamepad_get_axis_value_rawwithfalseinstead ofgamepad_get_axis_value.gamepad_get_axis_valueactually clamps the control stick values so I don't think we want this.This code was tested by Ninjiteu (the one who filed this bug) and it works perfectly based on his testing.
Related Issues
#15776
Related Issues
@gblues