(cheevos) use rc_client for state management #15912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
* use rc_client for achievement processing * log disconnect/reconnect messages * address compiler warnings * address c89 warning * address c89 warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This modifies the cheevos code to leverage the new
rc_clientstructure provided by rcheevos 11.0 to manage the loaded game assets (achievements, leaderboards) and more tightly integrate the API calls (less stuff managed outside rcheevos makes the library more portable to other clients). This code is already live in two standalone emulators, and I've been testing it in RetroArch for a week, so I have a fairly high level of confidence in it.At this time, I've chosen to use a conditional compilation flag (
HAVE_RC_CLIENTincheevos_locals.h). If needed, commenting that out will restore the old functionality. The old code will be removed in a future PR.Related Issues
n/a
Related Pull Requests
n/a
Reviewers
@Sanaki