(WASAPI) Shared buffer refactor + cleanup #15929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setting_action_ok_uint_special()
doesatoi()
on themBasically now the shared mode also uses the common Audio Latency buffer size as buffer period when the shared buffer value is at default 0. Also basically this makes the separate shared buffer option useless, since too small buffer period already automatically uses the minimum usable shared buffer size (Client Buffer), but let's keep it for now until more data is gathered, also relating to the same option for microphone. Hopefully we can get rid of both of them eventually.
The goal is to get consistent performance with differently behaving cores with the default values like every other driver, and allow tweaking for better latency. Currently increasing the buffer size does nothing, because the used buffer size is always limited by the Client Buffer size, because the shared client is initialized with buffer period size 0 regardless of Audio Latency, and Audio Latency is ignored completely.
Related Issues
#15920