-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate FreeBSD port patches #16221
Conversation
Can you fix the failed CI build error? |
Apparently, the FreeBSD macro is also activated for the ORBIS builds, which I did not anticipate. I'll try a few things and will squash the commits if the pipeline reports success. |
This commit imports a series of patches from the FreeBSD port of RetroArch to improve build compatibility and address specific issues encountered in the FreeBSD environment. These patches, sourced from the FreeBSD Ports collection (https://cgit.freebsd.org/ports/tree/games/retroarch/files), have been adapted and tested to ensure they integrate seamlessly with the current build process.
92a9f9b
to
387675f
Compare
I've fixed the PS4/ORBIS CI build and squashed all the commits. Is there any chance we could get a FreeBSD amd64 CI runner? |
Incorporate changes from a pull request for improved traceability and documentation. See libretro/RetroArch#16221 This is a NOP change and does not warrant a PORTREVISION bump.
We will need to add Cirrus CI or Travis CI ? We have Travis but it will need some update to make it work again (was used for coverity scan IIRC). |
I'd go with Travis if you already got it. But there is no hurry. It would be nice to have. |
Hi @gouchi, I was wondering if we might have an opportunity to merge this while it's conflict-free? Also, if you think it would be helpful, I'm more than willing to open a separate issue to discuss the pipeline in more detail. Please let me know your thoughts or if there's anything else I can do to assist. Thanks so much for your time and efforts! |
@ehaupt Sure we can discuss the pipeline in more detail to a separate issue to enable FreeBSD CI test. @LibretroAdmin CI build error has been fixed. |
I tested on FreeBSD 14.1 and I confirm that the patches are needed to compile RA.
If needed configure and gmake ouput. Without it you got this error. @LibretroAdmin This PR should be good to be merged. Thank you. P.S = I had to disable Discord otherwise you got linking issue but it is not related to this PR and it is also disable on FreeBSD. |
Any chance this could be merged? |
This commit imports a series of patches from the FreeBSD port of RetroArch to improve build compatibility and address specific issues encountered in the FreeBSD environment. These patches, sourced from the FreeBSD Ports collection (https://cgit.freebsd.org/ports/tree/games/retroarch/files), have been adapted and tested to ensure they integrate seamlessly with the current build process.
Description
This commit integrates a series of patches from the FreeBSD port, enhancing build compatibility and resolving specific FreeBSD-related issues. They tackle a variety of issues, including compiler warnings and system-specific dependencies.
Related Issues
Related Pull Requests